Skip to content

relnote(117): Windows notifications have requireInteraction set to true by default#28855

Merged
Rumyra merged 4 commits intomdn:mainfrom
bsmth:28756-requireInteraction
Sep 1, 2023
Merged

relnote(117): Windows notifications have requireInteraction set to true by default#28855
Rumyra merged 4 commits intomdn:mainfrom
bsmth:28756-requireInteraction

Conversation

@bsmth
Copy link
Copy Markdown
Member

@bsmth bsmth commented Aug 30, 2023 •
edited
Loading

Windows notifications require user interaction (dismiss) by default via dom.webnotifications.requireinteraction.enabled pref

Related issues and pull requests:

Bugzilla:

@bsmth bsmth requested a review from dipikabh August 30, 2023 16:43
@bsmth bsmth requested a review from a team as a code owner August 30, 2023 16:43
@github-actions github-actions bot added the Content:Firefox Content in the Mozilla/Firefox subtree label Aug 30, 2023
@bsmth bsmth mentioned this pull request Aug 30, 2023
Closed
12 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 30, 2023 •
edited
Loading

Preview URLs

Flaws (9)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/117
Title: Firefox 117 for developers
Flaw count: 9

  • macros:
    • /en-US/docs/Web/API/RTCRtpScriptTransform does not exist
    • /en-US/docs/Web/API/RTCRtpScriptTransformer does not exist
    • /en-US/docs/Web/API/RTCRtpSender/transform does not exist
    • /en-US/docs/Web/API/RTCRtpReceiver/transform does not exist
    • /en-US/docs/Web/API/RTCEncodedVideoFrame does not exist
    • and 3 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/WebRTC_API/Using_Encoded_Transforms
External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox

(comment last updated: 2023-08-31 15:18:03)

@bsmth bsmth mentioned this pull request Aug 30, 2023
Merged
2 tasks
@dipikabh dipikabh self-assigned this Aug 30, 2023
dipikabh
dipikabh requested changes Aug 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates, @bsmth 🙏.

Left a few comments.

@bsmth bsmth requested a review from a team as a code owner August 31, 2023 09:54
@bsmth bsmth requested review from wbamberg and removed request for a team August 31, 2023 09:54
@github-actions github-actions bot added the Content:WebAPI Web API docs label Aug 31, 2023
@bsmth bsmth requested a review from dipikabh August 31, 2023 09:56
@wbamberg wbamberg removed their request for review August 31, 2023 15:52
dipikabh
dipikabh reviewed Aug 31, 2023
View reviewed changes
files/en-us/web/api/notification/requireinteraction/index.md
Copy link
Copy Markdown
Contributor

@dipikabh dipikabh Aug 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not remove experimental status yet because it still does need a preference to be set in the release build (except on Windows). But the remaining changes look good, so I'll leave an approval.

Thanks for your work on this!

@Rumyra Rumyra merged commit 1bae6d3 into mdn:main Sep 1, 2023
@bsmth bsmth deleted the 28756-requireInteraction branch September 1, 2023 10:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dipikabh dipikabh dipikabh approved these changes

Assignees

@dipikabh dipikabh

Labels

Content:Firefox Content in the Mozilla/Firefox subtree Content:WebAPI Web API docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bsmth @dipikabh @Rumyra