Skip to content

Page orientation 24390#25176

Merged
dipikabh merged 32 commits intomdn:mainfrom
CodeRedDigital:page-orientation-24390
Mar 15, 2023
Merged

Page orientation 24390#25176
dipikabh merged 32 commits intomdn:mainfrom
CodeRedDigital:page-orientation-24390

Conversation

@dletorey
Copy link
Copy Markdown
Contributor

@dletorey dletorey commented Mar 8, 2023

Description

Added documentation for the page-orientation descriptor for the @page at-rule

Motivation

Documenting for the Firefox preview release for page-orientation

Additional details

Related issues and pull requests

@dletorey dletorey requested a review from a team as a code owner March 8, 2023 12:46
@dletorey dletorey requested review from dipikabh and removed request for a team March 8, 2023 12:46
@github-actions github-actions Bot added the Content:CSS Cascading Style Sheets docs label Mar 8, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 8, 2023

Preview URLs

(comment last updated: 2023-03-15 10:39:00)

@dipikabh dipikabh self-assigned this Mar 9, 2023
Copy link
Copy Markdown
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting this, @dletorey!

I've added a few comments and suggestions.

Comment thread files/en-us/web/css/@page/index.md Outdated
Comment thread files/en-us/web/css/@page/page-orientation/index.md Outdated
Comment thread files/en-us/web/css/@page/page-orientation/index.md Outdated
Comment thread files/en-us/web/css/@page/page-orientation/index.md Outdated
Comment thread files/en-us/web/css/@page/page-orientation/index.md Outdated
Comment thread files/en-us/web/css/@page/page-orientation/index.md
Comment thread files/en-us/web/css/@page/page-orientation/index.md Outdated

### Result

Click the print button to see the pages rotated.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be different example blocks to demo the other orientations Landscape/Left, Landscape/Right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shows both orientations, so I don't think so

Comment thread files/en-us/web/css/@page/page-orientation/index.md
Comment thread files/en-us/web/css/@page/page-orientation/index.md Outdated
dletorey and others added 3 commits March 15, 2023 09:53
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
dletorey and others added 11 commits March 15, 2023 10:00
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey dletorey requested a review from dipikabh March 15, 2023 10:38
Copy link
Copy Markdown
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the updates, @dletorey.

@dipikabh dipikabh merged commit 0e015f0 into mdn:main Mar 15, 2023
@dletorey dletorey deleted the page-orientation-24390 branch March 15, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants