Skip to content

Update ServiceWorkerRegistration updatefound event to new structure#14543

Merged
teoli2003 merged 2 commits intomdn:mainfrom
Elchi3:swr-event
Apr 1, 2022
Merged

Update ServiceWorkerRegistration updatefound event to new structure#14543
teoli2003 merged 2 commits intomdn:mainfrom
Elchi3:swr-event

Conversation

@Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Apr 1, 2022

@Elchi3 Elchi3 requested review from a team as code owners April 1, 2022 08:45
@Elchi3 Elchi3 requested review from Rumyra and removed request for a team April 1, 2022 08:45
@github-actions github-actions bot added the Content:WebAPI Web API docs label Apr 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022 •
edited
Loading

Preview URLs

Flaws

URL: /en-US/docs/Web/API/ServiceWorkerRegistration
Title: ServiceWorkerRegistration
on GitHub
Flaw count: 3

  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/ServiceWorkerRegistration/updatefound_event
Title: ServiceWorkerRegistration: updatefound event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.ServiceWorkerRegistration.updatefound_event

External URLs

URL: /en-US/docs/Web/API/ServiceWorkerRegistration
Title: ServiceWorkerRegistration
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/ServiceWorkerRegistration/updatefound_event
Title: ServiceWorkerRegistration: updatefound event
on GitHub

No new external URLs

(this comment was updated 2022-04-01 10:22:02.205095)

teoli2003
teoli2003 suggested changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny nit and we can land this.

files/en-us/web/api/serviceworkerregistration/updatefound_event/index.md Outdated

## See also

- [Using Service
Copy link
Contributor

@teoli2003 teoli2003 Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small nit: can you put this link on one line, please?

teoli2003
teoli2003 approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@teoli2003 teoli2003 merged commit 5383870 into mdn:main Apr 1, 2022
@Elchi3 Elchi3 deleted the swr-event branch April 1, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rumyra Rumyra Awaiting requested review from Rumyra Rumyra was automatically assigned from mdn/yari-content-web-api

1 more reviewer

@teoli2003 teoli2003 teoli2003 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Content:WebAPI Web API docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Elchi3 @teoli2003