Skip to content

MIDIAccess and MIDIPort statechange_event#14034

Merged
teoli2003 merged 1 commit intomdn:mainfrom
Rumyra:accessstatechange
Mar 18, 2022
Merged

MIDIAccess and MIDIPort statechange_event#14034
teoli2003 merged 1 commit intomdn:mainfrom
Rumyra:accessstatechange

Conversation

@Rumyra
Copy link
Collaborator

@Rumyra Rumyra commented Mar 18, 2022

Summary

Firstly apologies for doing two at once, but they were so closely related (same event type) and the changes touched all the same pages apart from the event pages themselves it seemed worth it (and still not a big pr)

This changes MIDIAccess.onstatechange to MIDIAccess.statechange_event & MIDIPort.onstatechange to MIDIPort.statechange_event using new template. API landing plus other API pages & interface pages updated to reflect

Related issues

Tracking mdn/browser-compat-data#14578
Also part of #12792

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@Rumyra Rumyra requested review from a team as code owners March 18, 2022 16:54
@Rumyra Rumyra requested review from dipikabh and jpmedley and removed request for a team March 18, 2022 16:54
@github-actions github-actions bot added the Content:WebAPI Web API docs label Mar 18, 2022
@Rumyra Rumyra requested review from queengooborg and teoli2003 and removed request for dipikabh and jpmedley March 18, 2022 16:54
@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2022

Preview URLs

Flaws

Note! 6 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/MIDIAccess
Title: MIDIAccess
on GitHub
Flaw count: 1

  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/API/MIDIPort
Title: MIDIPort
on GitHub
Flaw count: 1

  • bad_bcd_links:
    • no explanation!

External URLs

URL: /en-US/docs/Web/API/MIDIConnectionEvent
Title: MIDIConnectionEvent
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MIDIConnectionEvent/port
Title: MIDIConnectionEvent.port
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MIDIConnectionEvent/MIDIConnectionEvent
Title: MIDIConnectionEvent.MIDIConnectionEvent()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Web_MIDI_API
Title: Web MIDI API
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MIDIAccess
Title: MIDIAccess
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MIDIAccess/statechange_event
Title: MIDIAccess: statechange event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MIDIPort
Title: MIDIPort
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MIDIPort/statechange_event
Title: MIDIPort: statechange event
on GitHub

No new external URLs

@Rumyra Rumyra mentioned this pull request Mar 18, 2022
Merged
teoli2003
teoli2003 approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Doing 2 at once is perfectly fine!

@teoli2003 teoli2003 merged commit 1e9f2e9 into mdn:main Mar 18, 2022
@Rumyra Rumyra mentioned this pull request Mar 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@queengooborg queengooborg Awaiting requested review from queengooborg

1 more reviewer

@teoli2003 teoli2003 teoli2003 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Content:WebAPI Web API docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Rumyra @teoli2003