Conversation
Contributor
Contributor
|
Checklist I used for reviewing this event Content PR: When
On the API interface page:
On each page of the interface and the API overview page:
Optional:
Administration:
|
teoli2003
suggested changes
Mar 9, 2022
Contributor
teoli2003
left a comment
There was a problem hiding this comment.
This is really good. A few nit and a couple of things to move around.
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Collaborator
Author
|
I think I've address everything @teoli2003 I just need to take a look at bcd next 👍 |
teoli2003
suggested changes
Mar 10, 2022
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
teoli2003
approved these changes
Mar 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onmidimessageshould bemidimessage_eventMotivation
Updating midi docs, so good chance to change the event pages - this pr tackles
onmidimessage. This is my first go so am drafting and pinging @teoli2003 @Elchi3 or @queengooborg for review 🙏 (Also not I haven't checked bcd yet - I wasn't sure what comes first)Metadata
Part of #12792