Adapt IDBTransaction & IDBDatabase events to the new event structure#13040
Merged
Adapt IDBTransaction & IDBDatabase events to the new event structure#13040
Conversation
Contributor
Merged
10 tasks
Elchi3
requested changes
Feb 16, 2022
Member
Elchi3
left a comment
There was a problem hiding this comment.
Nice work on dealing with a bubbling case here! There is some markdown error in one file that needs checking but overall it looks good to me.
I will describe how to do bubbling in the meta docs given it has worked for both you and me this way now.
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Elchi3
reviewed
Feb 16, 2022
Elchi3
approved these changes
Feb 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
IDBTransaction&IDBDatabaseinterfaces for new-style event pages. (see the template).On
IDBTransaction:abortanderrorare bubbling,completenot.On
IDBDatabase:closeandversionchangeevents.Link to the companion bcd PR: mdn/browser-compat-data#15006
1. If the XYZ event is bubbling
yarn content delete Web/API/yyyyyyy/onXYZ --redirect /en-US/docs/Web/API/xxxxxx/XYZ_eventyarn content add-redirectyarn content delete Web/API/yyyyyyy/XYZ_event --redirect /en-US/docs/Web/API/yyyyyyy/XYZ_eventyarn content add-redirect2. When
onXYZexists andXYZ_eventnot, for eachonXYZyarn content move /Web/API/xxxx/onXYZ /Web/API/xxxx/XYZ_eventbrowser-compatfront-runner keytitlefront-runner key to:Interface: XYZ event(with ticks!)PropertyandEvent Handlerfrom the tag list and addEventinstead (more cleaning possible)onXYZ.onXYZpropertyEvent typesection (two texts possible! If inheritance is not onlyEvent, do these additional steps:{{InheritanceDiagram}}Event propertiessection and list the parameters, taken from the interface of the event typeonXYZis a link.onXYZis a link to the adequateXYZ_event3. When both
onXYZandXYZ_eventexist:onXYZtoXYZ_eventpageonXYZpropertyEvent typesection (two texts possible! If inheritance is not onlyEvent, do these additional steps:{{InheritanceDiagram}}Event propertiessection and list the parameters, taken from the interface of the event typeonXYZis a link.onXYZis a link to the adequateXYZ_eventyarn content delete Web/API/xxxx/onXYZ --redirect /en-US/docsWeb/API/xxxx/XYZ_event4. On the API interface page:
onXYZ.5. On each page of the interface and the API overview page:
onXYZ.onXYZ = event => { …}){{event}macro is left.6. Optional:
7. Administrative: