Skip to content

Fix events in AbortSignal#12865

Merged
Elchi3 merged 4 commits intomdn:mainfrom
teoli2003:Events-AbortSignal
Feb 9, 2022
Merged

Fix events in AbortSignal#12865
Elchi3 merged 4 commits intomdn:mainfrom
teoli2003:Events-AbortSignal

Conversation

@teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented Feb 9, 2022 •
edited
Loading

This PR updates the AbortSignal interface for new-style event pages. (see the template)

The on-* event handler pages are redirected to the eventname_event pages.

yarn content delete Web/API/AbortSignal/onabort --redirect=/en-US/docs/Web/API/AbortSignal/abort_event

BCD: mdn/browser-compat-data#14900

@teoli2003 teoli2003 requested a review from Elchi3 February 9, 2022 14:42
@teoli2003 teoli2003 requested review from a team as code owners February 9, 2022 14:42
@github-actions github-actions bot added the Content:WebAPI Web API docs label Feb 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2022 •
edited
Loading

Preview URLs

Flaws

URL: /en-US/docs/Web/API/AbortSignal
Title: AbortSignal
on GitHub
Flaw count: 4

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/API/AbortSignal/throwIfAborted
Title: AbortSignal.throwIfAborted()
on GitHub
Flaw count: 4

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/API/AbortSignal/abort_event
Title: AbortSignal: abort event
on GitHub
Flaw count: 3

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)

External URLs

URL: /en-US/docs/Web/API/AbortSignal
Title: AbortSignal
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AbortSignal/throwIfAborted
Title: AbortSignal.throwIfAborted()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/AbortSignal/abort_event
Title: AbortSignal: abort event
on GitHub

No new external URLs

(this comment was updated 2022-02-09 15:34:00.934999)

@teoli2003 teoli2003 mentioned this pull request Feb 9, 2022
Merged
Elchi3
Elchi3 requested changes Feb 9, 2022
View reviewed changes
@teoli2003 teoli2003 requested a review from Elchi3 February 9, 2022 15:34
@Elchi3 Elchi3 merged commit f30ab5c into mdn:main Feb 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees

No one assigned

Labels

Content:WebAPI Web API docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@teoli2003 @Elchi3