Skip to content

Update TextTrack cuechange event pages#12684

Merged
sideshowbarker merged 1 commit intomdn:mainfrom
Elchi3:events-texttrack
Feb 4, 2022
Merged

Update TextTrack cuechange event pages#12684
sideshowbarker merged 1 commit intomdn:mainfrom
Elchi3:events-texttrack

Conversation

@Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Feb 3, 2022

Update the cuechange event pages to new event pages layout.

Here, there was no oncuechange page, but there was https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers/oncuechange. I removed and redirected it with:

yarn content delete Web/API/GlobalEventHandlers/oncuechange --redirect=/en-US/docs/Web/API/TextTrack/cuechange_event

Now there are two pages documenting cuechange:

This is the first time I'm hitting a GlobalEventHandlers mixin case, so I appreciate if someone could double check my approach.

@Elchi3 Elchi3 requested review from a team as code owners February 3, 2022 15:10
@Elchi3 Elchi3 requested review from Rumyra and removed request for a team February 3, 2022 15:10
@github-actions github-actions bot added the Content:WebAPI Web API docs label Feb 3, 2022
@Elchi3 Elchi3 mentioned this pull request Feb 3, 2022
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2022

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/HTMLTrackElement
Title: HTMLTrackElement
on GitHub
Flaw count: 14

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/HTMLTrackElement/kind does not exist
    • /en-US/docs/Web/API/HTMLTrackElement/srclang does not exist
    • /en-US/docs/Web/API/HTMLTrackElement/label does not exist
    • and 3 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 1 more flaws omitted

URL: /en-US/docs/Web/API/HTMLTrackElement/cuechange_event
Title: HTMLTrackElement: cuechange event
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLTrackElement/track does not exist

URL: /en-US/docs/Web/API/GlobalEventHandlers
Title: GlobalEventHandlers
on GitHub
Flaw count: 31

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/GlobalEventHandlers/onpointerlockchange does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onpointerlockerror does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onprogress does not exist
    • and 11 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 10 more flaws omitted

URL: /en-US/docs/Web/API/TextTrack
Title: TextTrack
on GitHub
Flaw count: 2

  • bad_bcd_links:
    • no explanation!
    • no explanation!

External URLs

URL: /en-US/docs/Web/API/HTMLTrackElement
Title: HTMLTrackElement
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLTrackElement/cuechange_event
Title: HTMLTrackElement: cuechange event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/GlobalEventHandlers
Title: GlobalEventHandlers
on GitHub

No external URLs

URL: /en-US/docs/Web/API/TextTrack
Title: TextTrack
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/TextTrack/cuechange_event
Title: TextTrack: cuechange event
on GitHub

No new external URLs

sideshowbarker
sideshowbarker approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@sideshowbarker sideshowbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first time I'm hitting a GlobalEventHandlers mixin case, so I appreciate if someone could double check my approach.

Looks right to me

@sideshowbarker sideshowbarker merged commit 979e711 into mdn:main Feb 4, 2022
foolip
foolip reviewed Feb 4, 2022
View reviewed changes
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Elchi3 Elchi3 deleted the events-texttrack branch February 4, 2022 11:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

@Rumyra Rumyra Awaiting requested review from Rumyra Rumyra was automatically assigned from mdn/yari-content-mdn

+1 more reviewer

@foolip foolip foolip left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Content:WebAPI Web API docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Elchi3 @sideshowbarker @foolip