Skip to content

String.prototype.includes is incorrectly marked as deprecated #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Elchi3 merged 1 commit into from
Feb 9, 2018
Merged

String.prototype.includes is incorrectly marked as deprecated #974

Elchi3 merged 1 commit into from
Feb 9, 2018

Conversation

@poke
Copy link
Contributor

@poke poke commented Feb 8, 2018

The compatibility table for String.prototype.includes shows that the “Basic support” is deprecated.

I assume the reason for this is that the data was originally converted from String.prototype.contains which indeed no longer exists. But of course includes is actually propertly standardized and fine to use.

Elchi3
Elchi3 approved these changes Feb 9, 2018
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you!

@Elchi3 Elchi3 added the data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Feb 9, 2018
@Elchi3 Elchi3 merged commit 883d6b0 into mdn:master Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees

No one assigned

Labels

data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@poke @Elchi3