Skip to content

Change ordering for String.prototype.includes #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
teoli2003 merged 2 commits into from
Feb 7, 2018
Merged

Change ordering for String.prototype.includes #953

teoli2003 merged 2 commits into from
Feb 7, 2018

Conversation

@toshotosho
Copy link
Contributor

@toshotosho toshotosho commented Feb 7, 2018

as suggested in #950

@teoli2003 teoli2003 added the data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Feb 7, 2018
teoli2003
teoli2003 approved these changes Feb 7, 2018
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r+

WednesdayDocs FTW!

@teoli2003 teoli2003 merged commit a33ae14 into mdn:master Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@teoli2003 teoli2003 teoli2003 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@toshotosho @teoli2003