Add Edge support of 'grid-template-columns:repeat()' #939
Conversation
|
Good catch @sorskoot ! @erikadoyle Can you check something for us here? Have repeat() and minmax() being added at the same time as grid-columns-repeat has been added, that is Edge 16 (like fit-content() )? Thanks a lot! |
Support is there since version 16.
Support was added in version 16.
The examples of percentage values work in Edge 16.
|
I did some more testing using Browserstack and ran through all grid related properties. These are working since Edge 16. I tested them on Edge 15, 16 and 17 using this pen https://codepen.io/Sorskoot/pen/EQyWyO?editors=0010 I accidentally added the commits to the existing pull request. Sorry. |
|
Wow, thank you @sorskoot! These must have shipped with our updated grid implementation, but I just noticed (thanks to your PR) that our Edge IDL doesn't yet account for CSS function values (thus it slipped past our diffing script). I'll look into how we can better monitor these going forward. |
Elchi3
left a comment
There was a problem hiding this comment.
Cool! Thanks everyone for the research here!
|
@sorskoot Thanks a lot. By the way, adding the commits to the PR was the right thing to do :-) |
I noticed it was working in Edge 17, but the documentation said it shouldn't...