Move <menuitem> behind a flag in Firefox 85#8019
Merged
ddbeck merged 2 commits intomdn:masterfrom Dec 23, 2020
Merged
Conversation
ddbeck
requested changes
Dec 18, 2020
Contributor
ddbeck
left a comment
There was a problem hiding this comment.
This looks really good, @rachelandrew. The only thing I'd suggest is preserving the notes from the unflagged support in the flagged support. From the bug, it doesn't look like the implementation changed at all—which makes sense a prelude to removal. Line comments to hopefully make that clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on mdn/content#294
Moving
<menuitem>behind a flag. I've set it as removed in 85 then a flag added in 85, let me know if there is a better way to represent this.Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1680596