Add compat data for text formatting CSS properties#725
Conversation
Elchi3
left a comment
There was a problem hiding this comment.
Just one tiny typo.
Regarding "overflow-wrap, which also goes under the non-standard alias word-wrap": It seems like the spec also has "word-wrap" now, so it is actually part of the standard. I like the way you've handled this with alternative_name.
The MDN page will query the data you've migrated here (under css.properties.overflow-wrap"), so I think it's fine.
We can add a similar data set under "css.properties.word-wrap", it would duplicate the data, but tools which strictly go by the CSS property names (like https://github.com/eduardoboucas/compat-report) would probably work better with the data available under the second name as well and it could point to overflow-wrap as an alternative_name the other way around.
css/properties/white-space.json
Outdated
| }, | ||
| "svg_support": { | ||
| "__compat": { | ||
| "description": "Suppor in SVG", |
|
OK, I've fixed the typo and I added a It might be nice to some day have this package to allow a sort of "see also" format (something like |
|
Great, thanks! I think the "see also" format is interesting. For APIs, there are sometimes entire feature trees that have the same compat data and we're repeating this info leading to some giant JSON files. On the other hand, and from a data consumer point of view, I feel like I don't want to deal with yet another thing to resolve for displaying the data :-) File an issue, good to have a discussion about this on record. |
This PR migrates the following text formatting CSS properties:
letter-spacingoverflow-wrapquoteswhite-spaceword-breakword-spacingOne thing I was not completely certain about here was
overflow-wrap, which also goes under the non-standard aliasword-wrap. I opted to usealternative_names to structure the support for the non-standard alias, though I think there might also be a case for making a separateword-wrap.jsonfile. If you would rather to see that happen, let me know and I'll update this PR. Thanks!