Remove never-supported HTML*Element APIs#6931
Conversation
9856d97 to
5a381ea
Compare
foolip
left a comment
There was a problem hiding this comment.
I haven't finished reviewing yet, submitting half a review.
| }, | ||
| "menu": { | ||
| "__compat": { | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLButtonElement/menu", |
There was a problem hiding this comment.
This is a 404. This entry came from wiki migration in #1132. I can't figure out what this ever was, but am pretty sure we should drop it from BCD.
There was a problem hiding this comment.
My investigation says whatwg/html#2342 removed it.
There was a problem hiding this comment.
Thanks for digging that up! Sounds like it was only ever shipped in Gecko, and it was removed here:
mozilla/gecko-dev@6ca8672
| } | ||
| } | ||
| }, | ||
| "setNfcFocus": { |
There was a problem hiding this comment.
This came from #2877. As a Firefox API for internal use only, we can remove it.
| @@ -1,148 +0,0 @@ | |||
| { | |||
| "api": { | |||
| "HTMLIsIndexElement": { | |||
There was a problem hiding this comment.
I think this should be paired with removal of https://github.com/mdn/browser-compat-data/blob/master/html/elements/isindex.json.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/isindex says "All major browsers have now removed <isindex>" but not when.
Per whatwg/html#1095 support was removed from Edge and Chrome back then, and Firefox was planning to remove. That happened here:
mozilla/gecko-dev@217ac88
WebKit support was dropped here:
https://trac.webkit.org/changeset/205858/webkit
So yes, this is far enough in the past that we can drop it from MDN/BCD.
There was a problem hiding this comment.
It's covered in #6955 but I can also do it here. Do you prefer to do it here?
There was a problem hiding this comment.
Nah, let's leave it in the other PR, I didn't know it was covered there.
foolip
left a comment
There was a problem hiding this comment.
Over to @chrisdavidmills, https://developer.mozilla.org/en-US/docs/Web/API/HTMLIsIndexElement needs to be removed.
| }, | ||
| "setNfcFocus": { | ||
| "__compat": { | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLIFrameElement/setNfcFocus", |
There was a problem hiding this comment.
| }, | ||
| "command": { | ||
| "__compat": { | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLMenuItemElement/command", |
There was a problem hiding this comment.
This is 404, no action needed.
| }, | ||
| "sortable": { | ||
| "__compat": { | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLTableElement/sortable", |
| }, | ||
| "stopSorting": { | ||
| "__compat": { | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLTableElement/stopSorting", |
| }, | ||
| "prompt": { | ||
| "__compat": { | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLIsIndexElement/prompt", |
| }, | ||
| "form": { | ||
| "__compat": { | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLIsIndexElement/form", |
| "api": { | ||
| "HTMLIsIndexElement": { | ||
| "__compat": { | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLIsIndexElement", |
There was a problem hiding this comment.
https://developer.mozilla.org/docs/Web/API/HTMLIsIndexElement will need to be removed.
foolip
left a comment
There was a problem hiding this comment.
Thanks @chrisdavidmills! I'll go ahead and merge this now.
A checklist to help your pull request get merged faster: