Updates to DOMPoint*, DOMRect*, and DOMQuad#4828
Merged
queengooborg merged 2 commits intomdn:masterfrom Sep 21, 2019
Merged
Conversation
Firefox 69 introduced several changes to these. In addition, a number of the existing entries were either missing or wrong, and several members that were added in the past were not listed. This should bring everything up to date. For the changes made, the sources are below. *For all of these, Edge is not available as the entire Geometry Interfaces API is under consideration still. For Safari, the API was almost completely implemented on first addition in Safari 10.1, with some stuff added in Safari 11.* Worker support information: * [Safari](https://trac.webkit.org/browser/webkit/branches/safari-603.1.30.0-branch/Source/WebCore/dom/DOMPoint.idl) * [Chrome](https://codereview.chromium.org/2650583009) * [Firefox](https://bugzilla.mozilla.org/show_bug.cgi?id=1420580) Addition of DOMQuad: * [Safari](https://trac.webkit.org/browser/webkit/branches/safari-603.1.30.0-branch/Source/WebCore/dom/DOMRect.idl) * [Firefox](https://bugzilla.mozilla.org/show_bug.cgi?id=917755) Addition of static constructors (fromPoint(), fromRect(), fromQuad()): * Safari: Present from the beginning * [Firefox](https://bugzilla.mozilla.org/show_bug.cgi?id=1558101) Thankfully, it's easy to bop around the WebKit code to isolate versions. I adore how well they've tagged and set up branches and releases to make it easy to identify releases that implement things.
queengooborg
requested changes
Sep 17, 2019
Contributor
queengooborg
left a comment
There was a problem hiding this comment.
Looking good so far! Just got a couple of changes I'd like to request:
- I suggested Opera, Opera Android, and Samsung Internet versions based upon the data we have. Just a little completionist-type change!
- iOS 10.3 was what had Safari 10.1. Can we update Safari iOS to say "10.3" whenever Safari Desktop is "10.1"? (I'm writing up a PR to remove those excess Safari iOS versions to reduce these issues in the future!)
- I noticed that DOMQuad was marked as Safari 11, yet the changeset you've linked shows it was implemented in at least 603.1.30, which would be present in Safari 10.1 (WebKit 603.2.1). Can you clarify the reason why this was marked as Safari 11 instead?
* Safari iOS 10.1 isn't a thing; it's actually 10.3. * Added information for Samsung and Opera/Opera Android * Confirmed that some other things were right, like DOMQuad's introduction in iOS 11.
queengooborg
approved these changes
Sep 21, 2019
Contributor
queengooborg
left a comment
There was a problem hiding this comment.
Thanks for the changes, looking good to me! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox 69 introduced several changes to these. In
addition, a number of the existing entries were either
missing or wrong, and several members that were
added in the past were not listed. This should bring
everything up to date.
For the changes made, the sources are below.
For all of these, Edge is not available as the entire
Geometry Interfaces API is under consideration still.
For Safari, the API was almost completely implemented on
first addition in Safari 10.1, with some stuff added in
Safari 11.
Worker support information:
Addition of DOMQuad:
Addition of static constructors (fromPoint(), fromRect(), fromQuad()):
Thankfully, it's easy to bop around the WebKit code
to isolate versions. I adore how well they've tagged
and set up branches and releases to make it easy
to identify releases that implement things.
A checklist to help your pull request get merged faster: