Merged
Conversation
teoli2003
suggested changes
Sep 19, 2017
Contributor
Author
|
Fixed the order. Thank you, @teoli2003! |
teoli2003
approved these changes
Sep 21, 2017
Contributor
|
LGTM, r+ |
This was referenced Oct 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the remaining border-bottom CSS properties:
border-bottomborder-bottom-colorborder-bottom-styleborder-bottom-widthOne thing that's not covered here is
-moz-border-bottom-colors, though it is referenced in notes (it's not a mere prefix, it's different behavior than the singular form). I assumed, since it's a Mozilla-only, non-standards-track property, that it's out of scope for this project. But I'm happy to add it in, if I'm mistaken.