Update AbortController Safari compatibility#3241
Merged
ddbeck merged 1 commit intomdn:masterfrom Jan 3, 2019
Merged
Conversation
ddbeck
requested changes
Jan 2, 2019
Contributor
ddbeck
left a comment
There was a problem hiding this comment.
Thanks for starting this PR! It looks pretty good, all we need is a couple style changes to the notes here. Thank you again!
According to https://bugs.webkit.org/show_bug.cgi?id=174980, while `AbortController` is present, and `fetch` will take an `AbortSignal`, it will never actually abort the request.
4956282 to
da99358
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://bugs.webkit.org/show_bug.cgi?id=174980, while
AbortControlleris present, andfetchwill take anAbortSignal, it will never actually abort the request. This affects Safari and iOS Safari.A quick test like http://temp.minimum.se/abort-native.html (from a comment in the ticket) proves this is indeed the case. I tested on macOS with Safari 12 and on latest iOS.
See also https://caniuse.com/#feat=abortcontroller.
A checklist to help your pull request get merged faster: