Chrome 144 adds subgroup_id WGSL language feature#28891
Conversation
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
| "deprecated": false | ||
| } | ||
| }, | ||
| "subgroup_id_num_subgroups": { |
There was a problem hiding this comment.
I think you have more context of whether it actually makes sense to record this subfeature here, but if we do, it would probably more consistent two have two subfeatures subgroup_id and num_subgroups.
There was a problem hiding this comment.
This is a bit of a tricky one. The trouble is, the actual WGSL language feature/extension that is available if the subgroups GPU feature is enabled is called subgroup_id. This WGSL language feature provides two WGSL built-ins called subgroup_id and num_subgroups.
By this token, it doesn't make sense to represent them as two separate WebAPI subfeatures, because they're not.
But you might have a better idea of how to represent this ;-)
| }, | ||
| "subgroup_id_num_subgroups": { | ||
| "__compat": { | ||
| "description": "`subgroup_id` and `num_subgroups` WGSL builtins available if `subgroups` feature enabled", |
There was a problem hiding this comment.
I think we can shorten this:
| "description": "`subgroup_id` and `num_subgroups` WGSL builtins available if `subgroups` feature enabled", | |
| "description": "`subgroup_id` and `num_subgroups` built-in values", |
There was a problem hiding this comment.
Related to my previous comment, I don't think this accurately represents the situation. These built-in values are not direct subfeatures of the subgroups feature, but they are available if it is enabled.
subgroup_id WGSL language feature
Summary
Chrome 144 adds support for the
subgroup_idWGSL language extension. See https://chromestatus.com/feature/5072447137251328, and also see https://developer.chrome.com/blog/new-in-webgpu-144#wgsl_subgroup_id_extension for further information.This PR adds two data points:
subgroup_idWGSL language extension itself, in the WGSLLanguageFeatures interface.subgroupsfeature needs to be enabled before thesubgroup_idWGSL language extension features are available.Test results and supporting details
Related issues