Skip to content

Firefox 92 maintains CSS accent-color contrast for legibility#26493

Merged
caugner merged 4 commits intomainfrom
26073-accent-color-contrast
Apr 14, 2025
Merged

Firefox 92 maintains CSS accent-color contrast for legibility#26493
caugner merged 4 commits intomainfrom
26073-accent-color-contrast

Conversation

@caugner
Copy link
Contributor

@caugner caugner commented Apr 11, 2025

Summary

Adds a subfeature maintains_contrast to CSS accent-color, which is only supported by Firefox.

Test results and supporting details

Tested with https://accent-color.glitch.me/ in Firefox 92 using BrowserStack Live.

Bugs:

Related issues

Fixes #26073.
Fixes #26381.

@caugner caugner requested a review from Elchi3 April 11, 2025 14:03
@github-actions github-actions bot added data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:m [PR only] 25-100 LoC changed labels Apr 11, 2025
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a description added

caugner and others added 3 commits April 14, 2025 23:32
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@caugner caugner merged commit 02c6640 into main Apr 14, 2025
12 checks passed
@caugner caugner deleted the 26073-accent-color-contrast branch April 14, 2025 21:43
@mdn-bot mdn-bot mentioned this pull request Apr 14, 2025
],
"support": {
"chrome": {
"version_added": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is slightly erroneous. I believe it works on desktop (though obviously will need to be confirmed) just not on Android.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks, you're right, Chrome maintains contrast since version 93, just Chrome Android doesn't. I will open a follow-up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:m [PR only] 25-100 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

css.properties.accent-color - Chrome Android should be partial Should css.properties.accent-color be partial or not?

3 participants