Bug-1771328 Persist WebExtensions menus fix note#26297
Closed
Bug-1771328 Persist WebExtensions menus fix note#26297
Conversation
Rob--W
requested changes
Mar 26, 2025
Member
Rob--W
left a comment
There was a problem hiding this comment.
The phrasing gives the impression that menu items did not persist before. That is not correct. There were only some cases where it disappeared, notably when an extension was reloaded or the browser was updated. Can this be phrased better? If it is too edge-casey, consider leaving it off entirely and rely on the release notes instead.
Contributor
Author
|
@Rob--W I'd be inclined not to add anything here. Not only is it perhaps rather edge-casey, it's also a bit imprecise, e.g., "more reliable" sounds like there are still cases where it might fail. |
Contributor
|
Given the last two comments, it sounds like we should close this PR. Is that correct, @rebloor? |
Contributor
Author
|
@dotproto indeed, that would seem like the way to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Provide a note in support of Bug 1771328 Restarting manifest v3 extension removes its context menu entry
Related issues
Update to release notes in mdn/content#38814