Skip to content

Add declarativeNetRequest.RuleCondition.domainType details#23639

Merged
rebloor merged 4 commits intomdn:mainfrom
rebloor:declarativeNetRequest.RuleCondition.domainType-implementation
Jul 18, 2024
Merged

Add declarativeNetRequest.RuleCondition.domainType details#23639
rebloor merged 4 commits intomdn:mainfrom
rebloor:declarativeNetRequest.RuleCondition.domainType-implementation

Conversation

@rebloor
Copy link
Copy Markdown
Contributor

@rebloor rebloor commented Jul 3, 2024

Summary

Add missing declarativeNetRequest.RuleCondition.domainType data, including "update" to reflect Firefox implementation in Bug 1797408 [DNR] Implement domainType (firstParty / thirdParty) condition

Related issues

Related MDN content in PR mdn/content#34577

@rebloor rebloor added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Jul 3, 2024
@rebloor rebloor requested a review from dotproto July 3, 2024 00:08
@rebloor rebloor self-assigned this Jul 3, 2024
@github-actions github-actions Bot added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Jul 3, 2024
Copy link
Copy Markdown
Contributor

@dotproto dotproto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rebloor, is it appropriate to review draft PRs like this or should I hold off until they're unflagged as draft?

@rebloor rebloor marked this pull request as ready for review July 18, 2024 09:51
@rebloor rebloor merged commit 7af0deb into mdn:main Jul 18, 2024
@rebloor rebloor deleted the declarativeNetRequest.RuleCondition.domainType-implementation branch July 18, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants