Skip to content

Support for match_origin_as_fallback in content_scripts manifest key#23553

Merged
rebloor merged 4 commits intomdn:mainfrom
rebloor:content-script-injection-into-data-URL-pages
Jul 1, 2024
Merged

Support for match_origin_as_fallback in content_scripts manifest key#23553
rebloor merged 4 commits intomdn:mainfrom
rebloor:content-script-injection-into-data-URL-pages

Conversation

@rebloor
Copy link
Copy Markdown
Contributor

@rebloor rebloor commented Jun 28, 2024

Summary

Update in support of Bug 1475831 WebExtension: content scripts should be injected in data URL pages, Bug 1896669 "Dark Background and Light Text" add-on stops working, and Bug 1853411 Implement matchOriginAsFallback in the scripting.registerContentScripts API

Related issues

MDN content changes in mdn/content#34491

@rebloor rebloor added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Jun 28, 2024
@rebloor rebloor requested a review from dotproto June 28, 2024 17:34
@rebloor rebloor self-assigned this Jun 28, 2024
@rebloor rebloor requested a review from Rob--W June 30, 2024 18:54
Copy link
Copy Markdown
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the one suggested change applied.

Comment thread webextensions/api/scripting.json Outdated
"__compat": {
"support": {
"chrome": {
"version_added": "119"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rob--W good to know that the reference I found in their doc was correct :-)
image

Co-authored-by: Rob Wu <rob@robwu.nl>
@rebloor rebloor marked this pull request as ready for review June 30, 2024 23:13
@rebloor rebloor merged commit 6bba19c into mdn:main Jul 1, 2024
@rebloor rebloor deleted the content-script-injection-into-data-URL-pages branch July 1, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants