Merged
Conversation
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Rob--W
approved these changes
Jul 1, 2024
Comment on lines
+23
to
+41
| "ExecutionWorld": { | ||
| "__compat": { | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": false | ||
| }, | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "128" | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "opera": "mirror", | ||
| "safari": { | ||
| "version_added": false | ||
| }, | ||
| "safari_ios": "mirror" | ||
| } | ||
| } | ||
| }, |
Member
There was a problem hiding this comment.
Suggested change
| "ExecutionWorld": { | |
| "__compat": { | |
| "support": { | |
| "chrome": { | |
| "version_added": false | |
| }, | |
| "edge": "mirror", | |
| "firefox": { | |
| "version_added": "128" | |
| }, | |
| "firefox_android": "mirror", | |
| "opera": "mirror", | |
| "safari": { | |
| "version_added": false | |
| }, | |
| "safari_ios": "mirror" | |
| } | |
| } | |
| }, |
The contentScripts.ExecutionWorld type doesn't exist.
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": false, | ||
| "impl_url": "https://bugzil.la/1736575" |
Member
There was a problem hiding this comment.
Also drop the note from
Rob--W
approved these changes
Jul 2, 2024
| "firefox": { | ||
| "version_added": "102", | ||
| "notes": "Only supports <code>ISOLATED</code>, not <code>MAIN</code>." | ||
| "version_added": "102" |
Member
There was a problem hiding this comment.
Hmm. Someone skimming this could mistakenly think that MAIN is supported in 102. Could you add multiple ranges to clarify that 102 only introduced support for ISOLATED, and 128 also added support for MAIN?
Rob--W
approved these changes
Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BCD in support of Bug 1736575 Support execution world MAIN in
scripting.executeScript()and content_scripts including:scripting.ExecutionWorldscripting.ExecutionWorldand theworldproperty tocontentScripts.register()Related issues
Related content changes are in mdn/content#34466