Add missing features for html.elements.iframe.allow#23487
Merged
Conversation
This PR adds the missing features of the `allow` member of the `iframe` HTML element. The data is copied from the Permissions-Policy header and then cleaned up accordingly.
caugner
requested changes
Oct 3, 2024
Contributor
caugner
left a comment
There was a problem hiding this comment.
Overall LGTM, just found three missing tags, and have two other comments, one about wildcards, the other about battery missing in the permission-policy feature.
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
Contributor
|
(@queengooborg Don't forget to re-request a review. 😉 ) |
caugner
reviewed
Oct 15, 2024
Contributor
caugner
left a comment
There was a problem hiding this comment.
Added tags look good, but my question about the wildcards value remains.
caugner
requested changes
Oct 18, 2024
html/elements/iframe.json
Outdated
| } | ||
| } | ||
| }, | ||
| "battery": { |
Contributor
There was a problem hiding this comment.
Looks like adding battery is not a good idea after all, because it isn't supported in any browser, so the linter complains:
browsers dating back two or more years ago.
✖ html.elements.iframe.allow.battery - Error → feature was never implemented.
html/elements/iframe.json
Outdated
| }, | ||
| "identity-credentials-get": { | ||
| "__compat": { | ||
| "spec_url": "https://fedidcg.github.io/FedCM/#permissions-policy-integration", |
Contributor
There was a problem hiding this comment.
The linter complains about this spec:
Spec URLs - 1 problem (1 error, 0 warnings):
✖ html.elements.iframe.allow.identity-credentials-get - Error → Invalid specification URL found: https://fedidcg.github.io/FedCM/#permissions-policy-integration. Check if:
- there is a more current specification URL
- the specification is listed in https://github.com/w3c/browser-specs
- the specification has a "good" standing
caugner
approved these changes
Oct 25, 2024
caugner
approved these changes
Oct 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing features of the
allowmember of theiframeHTML element. The data is copied from the Permissions-Policy header and then cleaned up accordingly.This fixes #15987, fixes #21979, fixes #23949.