Selection updates for parallel APIs ff125#23013
Merged
Conversation
8 tasks
hamishwillee
commented
May 6, 2024
hamishwillee
commented
May 6, 2024
hamishwillee
commented
May 6, 2024
hamishwillee
commented
May 6, 2024
hamishwillee
commented
May 6, 2024
| }, | ||
| "status": { | ||
| "experimental": true, | ||
| "standard_track": false, |
Contributor
Author
There was a problem hiding this comment.
FYI, spec only requires returning one range.
b63d80f to
a9d8204
Compare
Contributor
|
Hi @queengooborg, would it be possible for you to review this PR? |
Contributor
|
Hi @dipikabh, this is on my review queue already. No need to ping me after marking me for review. :) |
Elchi3
approved these changes
May 28, 2024
Member
Elchi3
left a comment
There was a problem hiding this comment.
Thanks @hamishwillee, looks reasonable to me. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FF126 adds
Selection.getComposedRanges()in nightly, but it also adds some updates to existing APIs:Selection.getComposedRanges()Selection.setBaseAndExtent()- this will now accept anchorNode and focusNode arguments that reside in different shadow trees, which will set the selection accordingly.Selection.collapse()- can now accept a node in any tree, and will collapse the range to that Node.extend()- This should work as-expected, even if the new focusNode is in a different shadow tree.There are other features coming but that is what is in now (according to https://bugzilla.mozilla.org/show_bug.cgi?id=1867058#c31)
FYI another thing that I don't know how to capture in BCD. I don' think I will:
Related work can be tracked in mdn/content#33180