Skip to content

relnote(116): CSSPropertyRule enabled in Fx nightly by default#20346

Merged
sideshowbarker merged 4 commits intomdn:mainfrom
bsmth:27756-css-properties-values-api
Jul 18, 2023
Merged

relnote(116): CSSPropertyRule enabled in Fx nightly by default#20346
sideshowbarker merged 4 commits intomdn:mainfrom
bsmth:27756-css-properties-values-api

Conversation

@bsmth
Copy link
Copy Markdown
Member

@bsmth bsmth commented Jul 12, 2023 •
edited
Loading

The pref layout.css.properties-and-values.enabled is set to true (enabled) on Nightly in 116. This allows for using the following APIs:

And the following CSS syntax:

@property --item-size {
  syntax: "<percentage>";
  inherits: true;
  initial-value: 40%;
}

pen/demo:
https://codepen.io/bsmth/pen/xxQpVow?editors=0111

Related issues and pull requests:

Bugzilla:

@github-actions github-actions Bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 12, 2023
@bsmth bsmth marked this pull request as draft July 12, 2023 15:18
@bsmth bsmth marked this pull request as ready for review July 12, 2023 15:52
@bsmth bsmth mentioned this pull request Jul 12, 2023
Merged
2 tasks
@github-actions github-actions Bot added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Jul 13, 2023
chrisdavidmills
chrisdavidmills approved these changes Jul 18, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; nice work @bsmth

@sideshowbarker sideshowbarker merged commit b649ff7 into mdn:main Jul 18, 2023
@bsmth bsmth mentioned this pull request Jul 24, 2023
Closed
12 tasks
@bsmth bsmth deleted the 27756-css-properties-values-api branch July 25, 2023 08:56
@bsmth
Copy link
Copy Markdown
Member Author

bsmth commented Jul 25, 2023

Thank you

@ZuBB
Copy link
Copy Markdown

ZuBB commented Sep 29, 2023

I spent an hour this morning and found that this does not work(broken?) in the nightly https://bugzilla.mozilla.org/show_bug.cgi?id=1846488

Right now, information about the presence of this feature in v119 is incorrect and may confuse users. Does it make sense to revert it?

@bsmth bsmth mentioned this pull request Nov 24, 2023
Merged
@bsmth
Copy link
Copy Markdown
Member Author

bsmth commented Nov 27, 2023

I spent an hour this morning and found that this does not work(broken?)

I'm sorry you wasted time on this! I've amended the entries in the linked PR with a note linking to https://bugzilla.mozilla.org/show_bug.cgi?id=1846516 ("Support interpolating registered custom properties") which you can track for the fixes and improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

@sideshowbarker sideshowbarker sideshowbarker approved these changes

Assignees

No one assigned

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bsmth @ZuBB @chrisdavidmills @sideshowbarker