Add compatibility data for scripting.ExecutionWorld#18878
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
779df3d to
4e36966
Compare
References: - "RegisteredContentScript.world" support introduced in Chrome 102 per https://chromium.googlesource.com/chromium/src/+/e5ad3451c17b21341b0b9019b074801c44c92c9f This is not supported in Firefox yet. - "executeScript"'s "world" was introduced in 95, not 88, per https://bugs.chromium.org/p/chromium/issues/detail?id=1215518 - "world" + "ISOLATED" introduced in Firefox per https://bugzilla.mozilla.org/show_bug.cgi?id=1759932 While that bug was fixed in 100, the underlying feature was not available until it was enabled in MV2 - https://bugzilla.mozilla.org/show_bug.cgi?id=1766615 "MAIN" not supported yet in Firefox, part of https://bugzilla.mozilla.org/show_bug.cgi?id=1736575
4e36966 to
e1963f1
Compare
rebloor
approved these changes
Feb 14, 2023
Contributor
|
@Rob--W Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the incorrect and incomplete BCD for the "world" parameter of the scripting.executeScript API.
Test results and supporting details
References:
"world" support introduced in Chrome 102 per https://chromium.googlesource.com/chromium/src/+/e5ad3451c17b21341b0b9019b074801c44c92c9f
"world" + "ISOLATED" introduced in Firefox per https://bugzilla.mozilla.org/show_bug.cgi?id=1759932 While that bug was fixed in 100, the underlying feature was not available until it was enabled in MV2 - https://bugzilla.mozilla.org/show_bug.cgi?id=1766615
"MAIN" not supported yet in Firefox, part of https://bugzilla.mozilla.org/show_bug.cgi?id=1736575
Related issues
Related to mdn/content#24316 and mdn/content#22493