RTCRtpSender.getParameters - remove returned dictionary?#18834
RTCRtpSender.getParameters - remove returned dictionary?#18834queengooborg merged 7 commits intomdn:mainfrom
Conversation
|
@queengooborg NOTE that I only intend to do this case because the values in RTCRtpParameters are not otherwise in BCD (and I will have to also do this for RTCRtpReceiver.getParameters() too. Each one of these keys is also a set of objects - so for example r Unless you think this is a cunning plan? |
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
|
Thanks @queengooborg Please merge this. I didn't see a response to the question below, so I'll just do it the way I want and see what you say :-)
|
|
@queengooborg Updated significantly - needs checking. So we have a dict
This copies the values for
|
| "version_added": "≤79" | ||
| }, | ||
| "firefox": { | ||
| "version_added": "46" |
There was a problem hiding this comment.
Note, there was a note in RTCRtpSendParameters compat data that this was implemented in RTCRtpParameters. However since we don't care about the dictionary I have simply removed the comment.
Is that OK? More specifically, spec compliance can be odd in that it expects you to implement in a particular way that will have no impact on compatibility.
queengooborg
left a comment
There was a problem hiding this comment.
This is LGTM, thank you! Always down for things we can do to remove the dictionaries that are still around!
RTCRtpSender.getParameters()returns a dictionary object of typeRTCRtpSendParameters, which in turn derives from RTCRtpParameters. The values inRTCRtpParametersare returned in all browsers but are not implemented in Firefox - i.e. they are empty or nothing values.@queengooborg My intent is to remove
RTCRtpSendParametersand RTCRtpParameters because we don't document dictionaries in general.I think the right thing to do is to add a subfeature for each option in the returned object under
RTCRtpSender.getParameters().Assuming I am correct, what is the naming pattern to represent each of the values of a returned object? Something like
return_object-has_Xxxx?Note the actual PR does not do that (yet). All it does is add a note in
RTCRtpSender.getParameters()to indicate that the FF implementation is partial and omits some values. This is just a placeholder.Note that this is IMO not sufficient because it loses information like the existance of the
degradationPreferencevalue inRTCRtpSendParameters(obsolete, but still present)