Remove timeupdate event from GlobalEventHandlers#16737
Merged
Conversation
foolip
requested changes
Jun 21, 2022
Contributor
foolip
left a comment
There was a problem hiding this comment.
There's already a "timeupdate_event" entry on HTMLMediaElement and that's the only one we should have. Can you trim this to just the removal?
foolip
approved these changes
Jun 21, 2022
Contributor
Author
|
Looks like no content updates were needed for this one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR demixes the
timeupdateevent from the GlobalEventHandlers mixin.