Skip to content

Demix slotchange event from GlobalEventHandlers#16733

Merged
queengooborg merged 16 commits intomdn:mainfrom
queengooborg:api/GlobalEventHandlers/slotchange
Jul 18, 2022
Merged

Demix slotchange event from GlobalEventHandlers#16733
queengooborg merged 16 commits intomdn:mainfrom
queengooborg:api/GlobalEventHandlers/slotchange

Conversation

@queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Jun 19, 2022

This PR demixes the slotchange event from the GlobalEventHandlers mixin.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 19, 2022
@queengooborg queengooborg mentioned this pull request Jun 19, 2022
Closed
@queengooborg queengooborg added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jun 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@foolip foolip mentioned this pull request Jun 23, 2022
Merged
foolip
foolip requested changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert the additions? There are already "slotchange_event" entries for HTMLSlotElement and ShadowRoot. I can only see it firing on HTMLSlotElement in Chromium, but I'm not confident enough about it to suggest removing the ShadowRoot entry. I'm asking in whatwg/dom#785 (comment) but that'll not block this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@foolip
Copy link
Contributor

foolip commented Jul 11, 2022

There's also a "slotchange_event" entry on ShadowRoot that we need to decide about. I think we should remove it, for the same reason we don't have all bubbling events on Document and Window.

@queengooborg queengooborg mentioned this pull request Jul 11, 2022
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg queengooborg merged commit f7f70c5 into mdn:main Jul 18, 2022
@queengooborg queengooborg deleted the api/GlobalEventHandlers/slotchange branch July 25, 2022 11:12
@Elchi3 Elchi3 removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Aug 18, 2022
@foolip foolip mentioned this pull request Sep 4, 2022
Closed
@saschanaz saschanaz mentioned this pull request Sep 17, 2022
Closed
@Elchi3 Elchi3 mentioned this pull request Sep 19, 2022
Merged
@Elchi3 Elchi3 mentioned this pull request Nov 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@foolip foolip foolip approved these changes

Assignees

No one assigned

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@queengooborg @foolip @Elchi3