Skip to content

Remove show event from GlobalEventHandlers#16732

Merged
queengooborg merged 6 commits intomdn:mainfrom
queengooborg:api/GlobalEventHandlers/show
Jul 10, 2022
Merged

Remove show event from GlobalEventHandlers#16732
queengooborg merged 6 commits intomdn:mainfrom
queengooborg:api/GlobalEventHandlers/show

Conversation

@queengooborg
Copy link
Contributor

This PR demixes the show event from the GlobalEventHandlers mixin.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 19, 2022
@queengooborg queengooborg added needs content update This PR needs a corresponding update to mdn/content to update the documentation and removed needs content update This PR needs a corresponding update to mdn/content to update the documentation labels Jun 19, 2022
@queengooborg
Copy link
Contributor Author

Looks like no content updates are needed for this one!

@foolip foolip added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 4, 2022
@foolip
Copy link
Contributor

foolip commented Jul 4, 2022

I think updates are needed to this page, which refer to an onshow property:
https://developer.mozilla.org/en-US/docs/Web/API/Element/show_event

@foolip
Copy link
Contributor

foolip commented Jul 4, 2022

Per spec there is no onshow on GlobalEventHandlers but there might have been in the past for something around <menu>. But we shouldn't demix it, just remove it. I'll revert the additions.

@foolip foolip changed the title Demix show event from GlobalEventHandlers Remove show event from GlobalEventHandlers Jul 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg
Copy link
Contributor Author

I've submitted a content PR (see mdn/content#18167), but I'm going to merge this PR before the content PR is because it does not block this PR.

@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 10, 2022
@queengooborg queengooborg merged commit a5b08b7 into mdn:main Jul 10, 2022
@queengooborg queengooborg deleted the api/GlobalEventHandlers/show branch July 10, 2022 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants