Skip to content

Demix invalid event from GlobalEventHandlers#16657

Merged
queengooborg merged 9 commits intomdn:mainfrom
queengooborg:api/GlobalEventHandlers/invalid
Jul 18, 2022
Merged

Demix invalid event from GlobalEventHandlers#16657
queengooborg merged 9 commits intomdn:mainfrom
queengooborg:api/GlobalEventHandlers/invalid

Conversation

@queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Jun 14, 2022

This PR demixes the invalid event from the GlobalEventHandlers mixin.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 14, 2022
@queengooborg queengooborg mentioned this pull request Jun 14, 2022
Closed
@queengooborg queengooborg added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jun 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

foolip
foolip requested changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are events for form controls, and are fired in 3 different places in the spec:
https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#statically-validate-the-constraints
https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#check-validity-steps
https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#report-validity-steps

I think we should have these events on the same 9 interfaces that have checkValidity() and reportValidity() methods. So far they're only on HTMLInputElement.

The additions made so far in this PR should be reverted.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg queengooborg mentioned this pull request Jul 17, 2022
Merged
@queengooborg queengooborg merged commit bded8da into mdn:main Jul 18, 2022
@queengooborg queengooborg deleted the api/GlobalEventHandlers/invalid branch July 25, 2022 11:12
@Elchi3 Elchi3 removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@foolip foolip foolip requested changes

Assignees

No one assigned

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@queengooborg @foolip @Elchi3