Skip to content

Demix error event from GlobalEventHandlers#16610

Merged
queengooborg merged 1 commit intomdn:mainfrom
queengooborg:api/GlobalEventHandlers/error
Jul 25, 2022
Merged

Demix error event from GlobalEventHandlers#16610
queengooborg merged 1 commit intomdn:mainfrom
queengooborg:api/GlobalEventHandlers/error

Conversation

@queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Jun 9, 2022

This PR demixes the error event from the GlobalEventHandlers mixin.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 9, 2022
@queengooborg queengooborg mentioned this pull request Jun 9, 2022
Closed
@queengooborg queengooborg added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jun 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@foolip
Copy link
Contributor

foolip commented Jun 22, 2022

There are lots of "error" events. Can you research which ones we already have and which are missing?

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@foolip
Copy link
Contributor

foolip commented Jul 5, 2022

I've reverted the additions, which aren't specific enough.

foolip
foolip requested changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (the string "error") is probably the most widely used event type, fired in lots of places. For this cleanup we only need to worry about the Node hierarchy and Window, however.

There's already an entry for Window, and these are the elements I can find where there's an "error" event:

  • HTMLImageElement
  • HTMLLinkElement
  • HTMLMediaElement (already in BCD)
  • HTMLObjectElement
  • HTMLScriptElement
  • HTMLSourceElement
  • HTMLStyleElement
  • HTMLTrackElement
  • SVGImageElement
  • SVGScriptElement
  • SVGStyleElement
  • SVGUseElement

Can you add all of these, and remove the "error_event" entry on Element? There is no generic "error" event, all of these are separate code paths.

@foolip
Copy link
Contributor

foolip commented Jul 5, 2022

Looks like there's also HTMLInputElement when type=image.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg queengooborg mentioned this pull request Jul 24, 2022
Open
@queengooborg queengooborg force-pushed the api/GlobalEventHandlers/error branch from 0fa74c3 to 7bbd95d Compare July 24, 2022 00:20
@queengooborg
Copy link
Contributor Author

queengooborg commented Jul 24, 2022

I've isolated this PR to only focus on removing the event handler from GEH, and have opened an issue for adding the event to the other interfaces. This should help us remove GEH while we get to the bottom of each interface!

@queengooborg queengooborg mentioned this pull request Jul 24, 2022
Merged
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 24, 2022
@queengooborg queengooborg merged commit 6152d9a into mdn:main Jul 25, 2022
@queengooborg queengooborg deleted the api/GlobalEventHandlers/error branch July 25, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@foolip foolip foolip approved these changes

Assignees

No one assigned

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@queengooborg @foolip