Remove canplay event from GlobalEventHandlers#16541
Merged
Conversation
foolip
requested changes
Jun 10, 2022
api/Document.json
Outdated
| } | ||
| } | ||
| }, | ||
| "canplay_event": { |
Contributor
There was a problem hiding this comment.
There's already a "canplay_event" entry for HTMLMediaElement and that's the only one we should have, as the event doesn't bubble. Can you revert the other additions, and then compare the data being removed to that existing entry, noting any discrepancies?
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
1 similar comment
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
foolip
approved these changes
Jun 21, 2022
Contributor
foolip
left a comment
There was a problem hiding this comment.
The remaining "canplay_event" on HTMLMediaElement looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR demixes the
canplayevents from the GlobalEventHandlers mixin.