Add a guideline for setting deprecated#15703
Merged
Conversation
Contributor
Author
|
(I figure that Ruth and Philip aren't really required for a review here, but I've tagged them as a courtesy.) |
queengooborg
requested changes
Apr 7, 2022
Contributor
queengooborg
left a comment
There was a problem hiding this comment.
LGTM, thank you! I just have some wording and formatting suggestions, feel free to decline any that don't seem reasonable!
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
Contributor
|
Cool cool - in which case approved from me once @queengooborg has :D |
queengooborg
approved these changes
Apr 12, 2022
Contributor
queengooborg
left a comment
There was a problem hiding this comment.
Thanks for the updates, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This provides some guidance on how to set the
deprecatedstatus, despite its somewhat misleading name.Test results and supporting details
I've been tidying up my branches and came across this thing. I think it mostly documents our existing practice, so hopefully this will be an uncontroversial addition to the data guidelines.