Skip to content

Adapt ShadowRoot API to new events structure#15201

Merged
foolip merged 3 commits intomdn:mainfrom
queengooborg:api/ShadowRoot/events
Apr 2, 2022
Merged

Adapt ShadowRoot API to new events structure#15201
foolip merged 3 commits intomdn:mainfrom
queengooborg:api/ShadowRoot/events

Conversation

@queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Mar 1, 2022

This PR adapts the ShadowRoot API to conform to the new events structure.

Note: there are no MDN pages associated with this event, so there will be no corresponding content PR. Any broken MDN URLs in BCD have been removed.

@queengooborg
Adapt ShadowRoot API to new events structure
4d2b86f 
This PR adapts the ShadowRoot API to conform to the new events structure.

Note: there are no MDN pages associated with this event, so there will be no corresponding content PR. Any broken MDN URLs in BCD have been removed.
@queengooborg queengooborg added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Mar 1, 2022
@queengooborg queengooborg mentioned this pull request Mar 1, 2022
Closed
foolip
foolip requested changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per https://groups.google.com/a/chromium.org/g/blink-dev/c/cagoIboJ6Oo/m/aCjiL_FBAgAJ this was a case of missing event handler property, while the event was supported earlier. This will require testing and partial_implementation ranges, possibly in Firefox and Safari too.

@queengooborg queengooborg self-assigned this Mar 19, 2022
@Elchi3
Copy link
Member

Elchi3 commented Apr 1, 2022

https://developer.mozilla.org/en-US/docs/Web/API/HTMLSlotElement/slotchange_event#browser_compatibility probably has the versions we want in the range here.

@Elchi3
Copy link
Member

Elchi3 commented Apr 1, 2022 

"slotchange_event": {
    "__compat": {
        "description": "<code>slotchange</code> event",
        "spec_url": "https://dom.spec.whatwg.org/#dom-shadowroot-onslotchange",
        "support": {
            "chrome": [
              {
                "version_added": "97"
              },
              {
                "version_added": "53",
                "version_removed": "97",
                "partial_implementation": true,
                "notes": "The <code>onslotchange</code> event handler property is not supported."
              }
            ],
            "chrome_android": [
              {
                "version_added": "97"
              },
              {
                "version_added": "53",
                "version_removed": "97",
                "partial_implementation": true,
                "notes": "The <code>onslotchange</code> event handler property is not supported."
              }
            ],
            "edge": [
              {
                "version_added": "97"
              },
              {
                "version_added": "53",
                "version_removed": "97",
                "partial_implementation": true,
                "notes": "The <code>onslotchange</code> event handler property is not supported."
              }
            ],
            "firefox": [
                {
                  "version_added": "93"
                },
                {
                  "version_added": "63",
                  "version_removed": "93",
                  "partial_implementation": true,
                  "notes": "The <code>onslotchange</code> event handler property is not supported."
                }
              ],
            "firefox_android": [
                {
                  "version_added": "93"
                },
                {
                  "version_added": "79",
                  "version_removed": "97",
                  "partial_implementation": true,
                  "notes": "The <code>onslotchange</code> event handler property is not supported."
                }
              ],
            "ie": {
                "version_added": false
            },
            "opera": [
                {
                  "version_added": "xx"
                },
                {
                  "version_added": "40",
                  "version_removed": "xx",
                  "partial_implementation": true,
                  "notes": "The <code>onslotchange</code> event handler property is not supported."
                }
              ],
            "opera_android": [
                {
                  "version_added": "68"
                },
                {
                  "version_added": "41",
                  "version_removed": "68",
                  "partial_implementation": true,
                  "notes": "The <code>onslotchange</code> event handler property is not supported."
                }
              ],
            "safari": [
                {
                  "version_added": "14.1"
                },
                {
                  "version_added": "10.1",
                  "version_removed": "14.1",
                  "partial_implementation": true,
                  "notes": "The <code>onslotchange</code> event handler property is not supported."
                }
              ],
            "safari_ios": [
                {
                  "version_added": "14.5"
                },
                {
                  "version_added": "10.3",
                  "version_removed": "14.5",
                  "partial_implementation": true,
                  "notes": "The <code>onslotchange</code> event handler property is not supported."
                }
              ],
            "samsunginternet_android": {
              "version_added": "6.0",
              "partial_implementation": true,
              "notes": "The <code>onslotchange</code> event handler property is not supported."
            },
            "webview_android": [
                {
                  "version_added": "97"
                },
                {
                  "version_added": "53",
                  "version_removed": "97",
                  "partial_implementation": true,
                  "notes": "The <code>onslotchange</code> event handler property is not supported."
                }
              ],
        },
        "status": {
            "experimental": false,
            "standard_track": true,
            "deprecated": false
        }
    }
}

@Elchi3 Elchi3 mentioned this pull request Apr 1, 2022
Merged
@foolip foolip merged commit 366cd46 into mdn:main Apr 2, 2022
@queengooborg queengooborg deleted the api/ShadowRoot/events branch April 3, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@foolip foolip foolip approved these changes

Assignees

@queengooborg queengooborg

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@queengooborg @Elchi3 @foolip