Skip to content

Adapt api.MediaKeySession.onkeystatuseschange to new events structure#15166

Merged
foolip merged 2 commits intomdn:mainfrom
queengooborg:api/MediaKeySession/keystatuseschange/events
Mar 29, 2022
Merged

Adapt api.MediaKeySession.onkeystatuseschange to new events structure#15166
foolip merged 2 commits intomdn:mainfrom
queengooborg:api/MediaKeySession/keystatuseschange/events

Conversation

@queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Feb 28, 2022

This PR adapts the keystatuseschange event of the MediaKeySession API to conform to the new events structure.

@queengooborg
Adapt api.MediaKeySession.onkeystatuseschange to new events structure
ba9bfea 
This PR adapts the keystatuseschange event of the MediaKeySession API to conform to the new events structure.
@queengooborg queengooborg added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API needs content update This PR needs a corresponding update to mdn/content to update the documentation labels Feb 28, 2022
This was referenced Feb 28, 2022
Closed
Merged
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Mar 7, 2022
foolip
foolip requested changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://source.chromium.org/chromium/chromium/src/+/6e3647df59a9b8a2c77d49ce5681e2a5b3ab7d17 shows that the event handler attributes were added after the events themselves. Can you add partial_implementation ranges?

@Elchi3
Copy link
Member

Elchi3 commented Mar 28, 2022

My guess is that this should be:

"chrome": [
  {
    "version_added": "55"
  },
  {
    "version_added": "42",
    "version_removed": "55",
    "partial_implementation": true,
    "notes": "The <code>onkeystatuseschange</code> event handler property is not supported."
  }
],

@Elchi3
Copy link
Member

Elchi3 commented Mar 28, 2022

(And similar for the other chromium based browsers)

foolip
foolip approved these changes Mar 29, 2022
View reviewed changes
api/MediaKeySession.json
},
"chrome": [
{
"version_added": "55"
Copy link
Contributor

@foolip foolip Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed by https://storage.googleapis.com/chromium-find-releases-static/6e3.html#6e3647df59a9b8a2c77d49ce5681e2a5b3ab7d17

@foolip foolip merged commit c1201e4 into mdn:main Mar 29, 2022
@queengooborg queengooborg deleted the api/MediaKeySession/keystatuseschange/events branch March 29, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@foolip foolip foolip approved these changes

Assignees

@queengooborg queengooborg

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@queengooborg @Elchi3 @foolip