Adapt api.HTMLInputElement.onsearch to new events structure#15159
Merged
Adapt api.HTMLInputElement.onsearch to new events structure#15159
Conversation
This PR adapts the search event of the HTMLInputElement API to conform to the new events structure. Note: there are no MDN pages associated with these events, so there will be no corresponding content PR. Any broken MDN URLs in BCD have been removed.
Contributor
|
This just removes the entry but the description doesn't say so. Was there a mistake? |
Contributor
Author
|
It wasn't a mistake, no -- there was simply nothing that needed to be added to the existing |
Contributor
|
I see, in that case it would be helpful to mention that in the description. |
foolip
reviewed
Mar 4, 2022
| "version_added": "14" | ||
| }, | ||
| "safari": { | ||
| "version_added": "1.3" |
Contributor
There was a problem hiding this comment.
This doesn't match the version in the "search_event" entry that remains. Can you check which is correct?
Contributor
Author
There was a problem hiding this comment.
Ack, this one slipped through -- the "1.3" came from tests I did a while back, and the "2" came from #11755 (comment). I'm going to stick with "2" on this one for the same reasons.
Contributor
There was a problem hiding this comment.
Alright, let's stick with Safari 2!
foolip
approved these changes
Mar 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adapts the search event of the HTMLInputElement API to conform to the new events structure.
Note: there are no MDN pages associated with these events, so there will be no corresponding content PR. Any broken MDN URLs in BCD have been removed.