Adapt api.Document.onreadystatechange to new events structure#15085
Merged
Adapt api.Document.onreadystatechange to new events structure#15085
Conversation
This PR adapts the readystatechange event of the Document API to conform to the new events structure.
Contributor
|
As far as I can tell, there's no corresponding |
Contributor
Author
|
There is -- no modifications were made to it because the data between the event handler and the event match! |
Elchi3
approved these changes
Feb 22, 2022
Member
Elchi3
left a comment
There was a problem hiding this comment.
I see the readystatechange_event, so this seems fine to me 👍
Contributor
|
Ah, for some reason GitHub's code search never turned up that feature (I have no idea why). Grepping turned up the feature. Sorry about that. (Though, for reviewer's convenience, it'd be nice to link to the related features, when they're not part of the diff.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adapts the readystatechange event of the Document API to conform to the new events structure.