Adapt Worker/Message API to new events structure#15046
Merged
Conversation
This PR adapts the DedicatedWorkerGlobalScope API to conform to the new events structure. Part of work for mdn#14578.
lucalves
approved these changes
Feb 20, 2022
ddbeck
reviewed
Feb 22, 2022
Contributor
ddbeck
left a comment
There was a problem hiding this comment.
A few questions here. Thank you!
| } | ||
| } | ||
| }, | ||
| "onmessage": { |
Contributor
There was a problem hiding this comment.
Another case where I'm not sure where this data went. What feature does this map to? Or if it doesn't exist, why isn't it added, based on this?
(My hunch here is that this PR is both demixing and consolidating events, but that's rather difficult to understand and verify from the diff alone.)
Contributor
Author
There was a problem hiding this comment.
For the WindowEventHandlers mixin, they have been merged into Window!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adapts the DedicatedWorkerGlobalScope, ServiceWorkerContainer, Window[EventHandlers], and Worker APIs to conform to the new events structure. Part of work for #14578.