Skip to content

Adapt BatteryManager events to the new event structure#14993

Merged
ddbeck merged 1 commit intomdn:mainfrom
teoli2003:Events-BatteryManager
Feb 15, 2022
Merged

Adapt BatteryManager events to the new event structure#14993
ddbeck merged 1 commit intomdn:mainfrom
teoli2003:Events-BatteryManager

Conversation

@teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented Feb 15, 2022

Part of #14578.

Per the new guideline: https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#dom-events-eventname_event

4 events: chargingchange_event, chargingtimechange_event, dischargingtimechange_event and levelchange_event.

Only cases where onXYZ exists, but not XYZ_event.

Move onXYZ to non-existingXYZ_event:

  • Rename onXYZ to XYZ_event
  • Change mdn_url to new MDN page
  • Add description before mdn_url: "description": "<code>XYZ</code> event",
  • Add second entry to spec_url
  • Run npm run fix to fix sort (if needed)
  • Run npm testto check all is fine
  • Open PR with name of events.
  • Add link to related content PR
  • Add "needs content update" label if content PR has not been merged.
  • Update description of Update event features according new data guideline #14578 so that it points to this PR

Content work: mdn/content#13021

@teoli2003 teoli2003 requested review from Elchi3 and ddbeck February 15, 2022 13:48
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 15, 2022
@teoli2003 teoli2003 added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Feb 15, 2022
Copy link
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right to me. Thank you! 🎉

@ddbeck ddbeck merged commit 88118dc into mdn:main Feb 15, 2022
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants