Adapt BatteryManager events to the new event structure#14993
Merged
Conversation
20 tasks
ddbeck
approved these changes
Feb 15, 2022
Contributor
ddbeck
left a comment
There was a problem hiding this comment.
Looks about right to me. Thank you! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #14578.
Per the new guideline: https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#dom-events-eventname_event
4 events:
chargingchange_event,chargingtimechange_event,dischargingtimechange_eventandlevelchange_event.Only cases where
onXYZexists, but notXYZ_event.Move
onXYZto non-existingXYZ_event:onXYZtoXYZ_eventmdn_urlto new MDN pagemdn_url:"description": "<code>XYZ</code> event",spec_urlnpm run fixto fix sort (if needed)npm testto check all is fineContent work: mdn/content#13021