Skip to content

Adapt Document fullscreen events to new structure#14939

Merged
sideshowbarker merged 1 commit intomdn:mainfrom
queengooborg:api/Document/fullscreen_events
Feb 11, 2022
Merged

Adapt Document fullscreen events to new structure#14939
sideshowbarker merged 1 commit intomdn:mainfrom
queengooborg:api/Document/fullscreen_events

Conversation

@queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Feb 11, 2022 •
edited
Loading

This PR updates the fullscreenchange and fullscreenerror events of the Document API to conform to the new style. Part of work for #14578.

Content PR: mdn/content#12926

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 11, 2022
This was referenced Feb 11, 2022
Merged
Closed
@sideshowbarker
Copy link
Member

sideshowbarker commented Feb 11, 2022

So I see this entirely deletes onfullscreenerror and onfullscreenchange and doesn’t add anything. That’s intended, right?

@sideshowbarker sideshowbarker merged commit 72a072f into mdn:main Feb 11, 2022
@queengooborg queengooborg deleted the api/Document/fullscreen_events branch February 11, 2022 23:21
@queengooborg
Copy link
Contributor Author

queengooborg commented Feb 11, 2022

So I see this entirely deletes onfullscreenerror and onfullscreenchange and doesn’t add anything. That’s intended, right?

Yes, this intended as the existing _event properties cover all the data already!

@Elchi3
Copy link
Member

Elchi3 commented Feb 14, 2022

So I see this entirely deletes onfullscreenerror and onfullscreenchange and doesn’t add anything. That’s intended, right?

Yes, this intended as the existing _event properties cover all the data already!

That's correct. However, we usually also add the spec_urls from the on-entries to the _event entries making it clear it's now the entry for both. See https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#dom-events-eventname_event for the full guideline.

@queengooborg
Copy link
Contributor Author

queengooborg commented Feb 14, 2022

@Elchi3 The reason I hadn't updated the spec_url is because it is the same URL for both members!

@Elchi3
Copy link
Member

Elchi3 commented Feb 15, 2022

Thanks @queengooborg, that makes sense then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@queengooborg @sideshowbarker @Elchi3