Remove MediaSessionAction[Details] from BCD#14071
Merged
Conversation
This PR removes `MediaSessionAction` and `MediaSessionActionDetails` from BCD. These features are a dictionary, enum, or WebIDL typedef and should not be included in BCD.
This was referenced Dec 18, 2021
Contributor
|
@queengooborg When you are removing these dictionaries, are you also "generally" checking that the data for the things that use them is correct? There is no issue if the caller that takes this object has matching versions, but I ran into one case (RTCIce something) where the versions did not match - so we were effectively throwing away information about options to a method changing over time. Note, I don't think it matters for this case. |
Contributor
Author
|
I am, yes! I'm giving a quick glance at the versions of each subfeature, and if they all match with the method's version, I'm refraining from creating subfeatures for the appropriate method. |
Contributor
|
Thanks for confirming :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
MediaSessionActionandMediaSessionActionDetailsfrom BCD. These features are a dictionary, enum, or WebIDL typedef and should not be included in BCD.Closes #4557.