Conversation
This PR updates and corrects the real values for Microsoft Edge for the `ongamepadconnected` and `ongamepaddisconnected` members of the `Window` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v4.0.0). Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/Window/ongamepadconnected _Check out the [collector's guide on how to review this PR](https://github.com/foolip/mdn-bcd-collector#reviewing-bcd-changes)._
foolip
reviewed
Dec 16, 2021
Contributor
|
@queengooborg the Edge data doesn't match Chrome still. And should we just go ahead and merge the event entries here, so that @Elchi3 doesn't need to combine the data in a second step soon? How should we capture a missing event handler property? |
Contributor
|
For the avoidance of doubt, I'd still like to see the event entries merge and for that to be reviewed by @Elchi3. |
Member
|
Happy to review merged events, yes. |
This was referenced Feb 12, 2022
foolip
requested changes
Feb 14, 2022
Contributor
|
For other reviewers for future archeologists, the evidence for this change is here: |
foolip
requested changes
Feb 17, 2022
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
foolip
requested changes
Feb 19, 2022
foolip
approved these changes
Feb 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates and corrects the real values for Chromium for the
ongamepadconnectedandongamepaddisconnectedmembers of theWindowAPI, based upon results from the mdn-bcd-collector project (v4.0.0).Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/Window/ongamepadconnected
Check out the collector's guide on how to review the version changes of this PR.
This PR also merges the event handles with the events to conform to the new style.
Content PR: mdn/content#12933