You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Second attempt to merge XHR events to single entries.
See #13598 (comment) for context
Here I'm removing XMLHttpRequestEventTarget entirely and events are installed on XMLHttpRequest and XMLHttpRequestUpload. I'm assuming same compat data, but I think @foolip assumes they are different. Happy to adjust.
Here I'm removing XMLHttpRequestEventTarget entirely and events are installed on XMLHttpRequest and XMLHttpRequestUpload. I'm assuming same compat data, but I think @foolip assumes they are different. Happy to adjust.
Indeed, because the upload property was added later than XHR itself, so all of the XMLHttpRequestUpload data should be clamped to those version. However, I see they're currently inconsistent, which we need to sort out first I think. @queengooborg can you confirm the correct versions for api.XMLHttpRequest.upload? I assume that the Safari data in particular is wrong, this must be older than Safari 10...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data:apiCompat data for Web APIs. https://developer.mozilla.org/docs/Web/API
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second attempt to merge XHR events to single entries.
See #13598 (comment) for context
Here I'm removing XMLHttpRequestEventTarget entirely and events are installed on XMLHttpRequest and XMLHttpRequestUpload. I'm assuming same compat data, but I think @foolip assumes they are different. Happy to adjust.