Correct Chromium data for Bluetooth APIs and make consistent#11715
Merged
Correct Chromium data for Bluetooth APIs and make consistent#11715
Conversation
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
foolip
requested changes
Aug 12, 2021
api/BluetoothDevice.json
Outdated
| "chrome": [ | ||
| { | ||
| "version_added": "56", | ||
| "notes": "macOS only." |
Contributor
There was a problem hiding this comment.
This is adding the old style structure. I'll fix in in a follow-up PR.
| }, | ||
| "chrome": [ | ||
| { | ||
| "version_added": "56", |
Contributor
There was a problem hiding this comment.
Confirmed with https://mdn-bcd-collector.appspot.com/tests/api/BluetoothUUID on macOS. 70 was wrong.
foolip
approved these changes
Aug 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a continuation off of #10197. While I was updating some of the Bluetooth APIs, I realized that I hadn't made the other APIs' style consistent with our changes. Additionally, I noticed a few errors in the data that we had. This PR corrects the erroneous data and makes our styling consistent across all of the Bluetooth APIs when representing the OS-specific support.
Fixes #11532.