Mark SVGGraphicsElement members as supported since ancient times#10564
Merged
Mark SVGGraphicsElement members as supported since ancient times#10564
Conversation
Contributor
Author
|
I went down this rabbit hole because getting rid of the Test results from http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=9295:
So since most of this is supported in all browsers going very far back I'm pretty confident, but I'm not sure about this being supported since Firefox 1.5 since I'm not good at Gecko source archeology. @vinyldarkscratch would you be able to test http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=9295 on Firefox 1.5 and see what it looks like? |
9ea7d0b to
f9b8309
Compare
http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=9339 was used to test for support of the interface itself. Results: - Chrome 30 (not in 29) - Not in IE11 - Edge 13 => Edge 12 assumed - Firefox 20 (not in 19) - Not in Opera 12.16 - Safari 6.2 (not in 6.0) => Safari 6.1 assumed http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=9295 was used to test for support for the members on concrete interfaces: ```html <!DOCTYPE html> <script> var members = ['transform', 'getBBox', 'getCTM', 'getScreenCTM']; var instances = { SVGAElement: document.createElementNS('http://www.w3.org/2000/svg', 'a'), SVGCircleElement: document.createElementNS('http://www.w3.org/2000/svg', 'circle'), SVGDefsElement: document.createElementNS('http://www.w3.org/2000/svg', 'defs'), SVGEllipseElement: document.createElementNS('http://www.w3.org/2000/svg', 'ellipse'), SVGForeignObjectElement: document.createElementNS('http://www.w3.org/2000/svg', 'foreignObject'), SVGGElement: document.createElementNS('http://www.w3.org/2000/svg', 'g'), SVGImageElement: document.createElementNS('http://www.w3.org/2000/svg', 'image'), SVGLineElement: document.createElementNS('http://www.w3.org/2000/svg', 'line'), SVGPathElement: document.createElementNS('http://www.w3.org/2000/svg', 'path'), SVGPolygonElement: document.createElementNS('http://www.w3.org/2000/svg', 'polygon'), SVGPolylineElement: document.createElementNS('http://www.w3.org/2000/svg', 'polyline'), SVGRectElement: document.createElementNS('http://www.w3.org/2000/svg', 'rect'), SVGSVGElement: document.createElementNS('http://www.w3.org/2000/svg', 'svg'), SVGSwitchElement: document.createElementNS('http://www.w3.org/2000/svg', 'switch'), SVGSymbolElement: document.createElementNS('http://www.w3.org/2000/svg', 'symbol'), SVGUseElement: document.createElementNS('http://www.w3.org/2000/svg', 'use'), }; for (var iface in instances) { var instance = instances[iface]; for (var i = 0; i < members.length; i++) { var member = members[i]; w(iface + '.' + member + ': ' + (member in instance)); } } </script> ``` Results: - IE9 supports everything except SVGForeignObjectElement, SVGSymbolElement and SVGSVGElement.transform - Edge 15 supports everything except SVGSymbolElement - Chrome 15, Firefox 3, Opera 12.16 and Safari 4 support everything except SVGSymbolElement and SVGSVGElement.transform SVGGraphicsElement was introduced in WebKit here: https://trac.webkit.org/changeset/152167/webkit https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/Configurations/Version.xcconfig?rev=152167 It combined SVGLocatable and SVGTransformable going back to the initial SVG support in Safari 3, which also shipped in Chrome 1: https://trac.webkit.org/browser/webkit/branches/old/Safari-3-branch/WebCore/ksvg2/svg/SVGLocatable.idl https://trac.webkit.org/browser/webkit/branches/old/Safari-3-branch/WebCore/ksvg2/svg/SVGTransformable.idl All together, the members are assumed to be supported from when SVG support was introduced in each browser.
f9b8309 to
5375995
Compare
Contributor
Author
|
See https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#apis-moved-on-the-prototype-chain for why the notes are the way they are. |
Contributor
Author
|
@Elchi3 this is going to block demixing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=9339 was
used to test for support of the interface itself. Results:
http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=9295 was
used to test for support for the members on concrete interfaces:
Results:
SVGSymbolElement and SVGSVGElement.transform
except SVGSymbolElement and SVGSVGElement.transform
SVGGraphicsElement was introduced in WebKit here:
https://trac.webkit.org/changeset/152167/webkit
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/Configurations/Version.xcconfig?rev=152167
It combined SVGLocatable and SVGTransformable going back to the initial
SVG support in Safari 3, which also shipped in Chrome 1:
https://trac.webkit.org/browser/webkit/branches/old/Safari-3-branch/WebCore/ksvg2/svg/SVGLocatable.idl
https://trac.webkit.org/browser/webkit/branches/old/Safari-3-branch/WebCore/ksvg2/svg/SVGTransformable.idl
All together, the members are assumed to be supported from when SVG
support was introduced in each browser.