Skip to content

Add insertIfAbsent#2

Merged
mcschroeder merged 1 commit intomcschroeder:masterfrom
DreamLinuxer:master
Apr 25, 2016
Merged

Add insertIfAbsent#2
mcschroeder merged 1 commit intomcschroeder:masterfrom
DreamLinuxer:master

Conversation

@DreamLinuxer
Copy link
Copy Markdown
Contributor

Add insertIfAbsent and related tests.

@mcschroeder
Copy link
Copy Markdown
Owner

I may get a chance to review these changes in detail next week (sorry for not responding sooner), until then, some quick observations: insertIfAbsent makes sense. But I'm skeptical about foldlWithKey, how does that work with concurrent modifications?

@DreamLinuxer
Copy link
Copy Markdown
Contributor Author

Sorry, I only want to add insertIfAbsent, other commit is irrelevant please ignore them.

@DreamLinuxer DreamLinuxer force-pushed the master branch 3 times, most recently from e17ff37 to 339b133 Compare April 20, 2016 18:29
@mcschroeder mcschroeder merged commit 62f6878 into mcschroeder:master Apr 25, 2016
@mcschroeder
Copy link
Copy Markdown
Owner

Looks good; merged. Thank you for your contribution! I will release a new version of the library on Hackage shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants