Skip to content

add running to typescript definition#71

Merged
mcollina merged 6 commits into
mcollina:masterfrom
Uzlopak:patch-1
Jun 25, 2023
Merged

add running to typescript definition#71
mcollina merged 6 commits into
mcollina:masterfrom
Uzlopak:patch-1

Conversation

@Uzlopak

@Uzlopak Uzlopak commented Jun 25, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@Uzlopak Uzlopak changed the title running-types add running to typescript definition Jun 25, 2023
@Uzlopak

Uzlopak commented Jun 25, 2023

Copy link
Copy Markdown
Contributor Author

When running the jsdoc typechecking with typescript in vscode on avvio, it is reporting that running is not defined.

image

@mcollina

Copy link
Copy Markdown
Owner

Can you add it to example.ts?

@Uzlopak

Uzlopak commented Jun 25, 2023

Copy link
Copy Markdown
Contributor Author

I originally wanted to add it, but example.ts seemed to be some working code example, so I hesitated.

Will add.

@Uzlopak

Uzlopak commented Jun 25, 2023

Copy link
Copy Markdown
Contributor Author

done.

@mcollina mcollina left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak

Uzlopak commented Jun 25, 2023

Copy link
Copy Markdown
Contributor Author

@mcollina
ptal

@mcollina mcollina merged commit be3943a into mcollina:master Jun 25, 2023
@Uzlopak Uzlopak deleted the patch-1 branch June 25, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants