fix: queueAsPromised.drained() resolves while queue is idle#64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #63 by returning early from
queueAsPromised.drainedwhen the queue is idle.NOTE: This implementation does NOT call
queue.drainif the queue is idle, which IMO makes sense. The docs state thatqueue.drainis a "Function that will be called when the last item from the queue has been processed by a worker." When the queue is idle and the user callsawait queue.drained(), it's reasonable to assume that the user has already added and processed items from the queue, soqueue.drainshould have already been called when the last item was processed.